Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search bar and timestamp sort to audit logs UI #5138

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

nickgerace
Copy link
Contributor

@nickgerace nickgerace commented Dec 16, 2024

Description

This PR adds a search bar to the Audit Logs UI and restores the ability to sort all logs by timestamp. In addition to these changes, the style of the dropdowns themselves have been slightly polished, including the "Filter by" text being centered and the empty logs text being more clear.

@github-actions github-actions bot added A-sdf Area: Primary backend API service [Rust] A-dal A-web A-dal-test labels Dec 16, 2024
@nickgerace nickgerace marked this pull request as ready for review December 16, 2024 19:39
@nickgerace nickgerace force-pushed the nick/000ca83 branch 3 times, most recently from 70323cf to 03a08aa Compare December 16, 2024 20:11
Copy link
Contributor

@wendybujalski wendybujalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just gotta fix that conditional and you'll be good to go!

lib/vue-lib/src/design-system/menus/DropdownMenuItem.vue Outdated Show resolved Hide resolved
This commit adds a search bar to the Audit Logs UI and restores the
ability to sort all logs by timestamp. In addition to these changes,
the style of the dropdowns themselves have been slightly polished,
including the "Filter by" text being centered and the empty logs text
being more clear.

Co-authored-by: Wendy Bujalski <[email protected]>
Signed-off-by: Nick Gerace <[email protected]>
Copy link
Contributor

@wendybujalski wendybujalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickgerace nickgerace added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 627ca41 Dec 16, 2024
9 checks passed
@nickgerace nickgerace deleted the nick/000ca83 branch December 16, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dal A-dal-test A-sdf Area: Primary backend API service [Rust] A-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants