Do not filter requirements by kind and other fixes #5394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
nickgerace
force-pushed
the
nick/9337ba7
branch
from
2e1f5a0 to
e5f6aa3
Compare
nickgerace
force-pushed
the
nick/9337ba7
branch
from
e5f6aa3 to
c639665
Compare
This commit ensures that the InsertApprovalModel no longer filters requirements based on entity kind. Now, it shows a requirment per entity and the labelling is expanded for this feature. This is NOT the final state we want to be in due to showing potentially too many and overwhelming results for the same approver groups and individuals, but this is a step in the right direction. This commit also ensures that the approval status data is up to date on the requester's side when requesting approvals. This is due to a potential race or missing edge case when the change set moves from an "open" to a "needsapproval" state. A corresponding "TODO" has been added to the problem area, but the current fix is sufficient in the interim. In addition to these changes, both the requirements and actions are now scrollable. We now also show the email for a user (though truncation may not work at this time) as well as right padding for the status text (e.g. "Waiting..." which has now been capitalized to match the other states). One final change, we now always allow users to reject the changes, even if all approvals have been met. Co-authored-by: Wendy Bujalski <[email protected]> Signed-off-by: Nick Gerace <[email protected]>
wendybujalski
force-pushed
the
nick/9337ba7
branch
from
2d759fe to
1a2699f
Compare
|
Closed in favor of #5403 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the InsertApprovalModel no longer filters requirements based on entity kind. Now, it shows a requirement per entity and the labelling is expanded for this feature. This is NOT the final state we want to be in due to showing potentially too many and overwhelming results for the same approver groups and individuals, but this is a step in the right direction.
This PR also ensures that the approval status data is up to date on the requester's side when requesting approvals. This is due to a potential race or missing edge case when the change set moves from an "open" to a "needsapproval" state. A corresponding "TODO" has been added to the problem area, but the current fix is sufficient in the interim.
In addition to these changes, both the requirements and actions are now scrollable. We now also show the email for a user (though truncation may not work at this time) as well as right padding for the status text (e.g. "Waiting..." which has now been capitalized to match the other states).
One final change, we now always allow users to reject the changes, even if all approvals have been met.