Does MICROBIN_EDITABLE=false do anything?

[rmzg]

I want to disable editing/removing uploads, especially when shared to other people, without having to set a password every single time I upload, but nothing I try seems to work. I've tried setting MICROBIN_EDITABLE=false but it doesn't seem to change anything. Reading through the code, it looks like editable is just always set to true? I can't find any place where you actually read the editable environment variable.

microbin/src/endpoints/create.rs

Line 94 in b8a0c54

editable: true,

[Virkkunen]

It seems a lot of the variables don't do anything as of now, check #221 #229

[rmzg]

Those are via the compose file, I'm talking about after that step.

…

On Fri, Nov 3, 2023, 3:11 AM Fred Almeida ***@***.***> wrote: It seems a lot of the variables don't do anything as of now, check #221 <#221> #229 <#229> — Reply to this email directly, view it on GitHub <#237 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJZFZ5O7ECXVJL5UJA4AVDYCSRMRAVCNFSM6AAAAAA6ZAWAQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSGAZDCOJUHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[0815pascal]

@rmzg What kind of environment are you deploying on? Assuming that you're talking about the variables set in a .env-file, you have to set them separately if deploying to fly.io for example. You then have to set MICROBIN_EDITABLE=false via CLI or the CI/CD-vendor's UI so as that it takes effect on the deployed version of your app.

[szabodanika]

The purpose of this specific parameter is to enable or disable editable uploads (see https://microbin.eu/docs/installation-and-configuration/configuration#microbin_editable). This was added back when there was an editable checkbox, now we have a dropdown with 5 different privacy settings that also change editability, and I don't think this parameter was adapted to this new system