Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --config argument #49

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

piyushkumbhare
Copy link
Contributor

@piyushkumbhare piyushkumbhare commented Jan 13, 2025

Added --config argument to CliArgs struct as a Option<String>. If provided, reads from args.config as a PathBuf, else defaults to .config_dir() like before.

Copy link
Owner

@szaffarano szaffarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for your contribution @piyushkumbhare 🚀

Please run cargo fmt (or even better, install and enable pre-commit) to fix the linting issue

@piyushkumbhare
Copy link
Contributor Author

Thank you! Sorry, this is my first ever public PR on an open source project so I'm a bit unfamiliar with the standards. I forgot to run cargo clippy and fmt but I have done so now. I will also look into the pre-commit tool you linked. Thank you so much!

@szaffarano szaffarano merged commit 1fdac1a into szaffarano:master Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants