Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata API Example to analyze CustomSQL prevalence on a Tableau Site #3

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

grbritz
Copy link
Contributor

@grbritz grbritz commented May 6, 2020

No description provided.

@grbritz grbritz requested a review from t8y8 May 6, 2020 00:21
Copy link
Contributor

@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a half done review.

I realized that you don't have much (any) error checking for calls out to the metadata API and results, my pager will handle some of that for you, so I'm going to finish that before I hit the second half.

samples/custom-sql-statistics/README.md Outdated Show resolved Hide resolved
samples/custom-sql-statistics/custom-sql-statistics.py Outdated Show resolved Hide resolved
samples/custom-sql-statistics/custom-sql-statistics.py Outdated Show resolved Hide resolved
samples/custom-sql-statistics/custom-sql-statistics.py Outdated Show resolved Hide resolved
samples/custom-sql-statistics/custom-sql-statistics.py Outdated Show resolved Hide resolved
samples/custom-sql-statistics/custom-sql-statistics.py Outdated Show resolved Hide resolved

query = """
{
customSQLTablesConnection(first: 20, after: AFTER_TOKEN_SIGNAL) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about me merging my graphql pager so you can use it -- Don't have to block on that for this review but reminder to both us us that I said I'd do that :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants