Add meta data #1323
Open
Add meta data #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: IconZoomIn, IconZoomOut are in "Map", this should be as well
Reason: icons precedes with 'map'
Reason: IconAB is related to AB test (as the tags indicate); IconAlt is a shortcut key; IconAuth2FA and IconLogs are highly related to software development; packages icons have tags "npm", so they are development-related too; IconPrompt and IconSourceCode are very obvious.
reason: they are all play cards
reason: all clothing and cloth hangers (there aren't much clothes icons currently, please determine if it's appropriate to do so)
reason: Joker is closely related to play cards
reason: all food/beverage containers
reason: IconToolsKitchen3 is uncategorized before, but IconToolsKitchen2 and IconToolsKitchen are currently in "Map". I'm not quite sure if this change is correct. Please reject this commit if I'm wrong.
reason: diaper is similar to clothes (sth. baby wear), perfume and flip flops are also sth. people "wear"
Reason: all other locks are now also in "System"
Reason: meter cube and meter square are related to math calculations
Reason: another lock.
Reason: all weapons.
Reason: another clothes.
Reason: window and wall are main parts of a building, a podium means a location(building with specific purpose) people give speech
Reason: horse toy is sth. children play with, archery arrow is part of a weapon
Reason: a weapon
Reason: all icons with a "scan frame". We already have IconBodyScan, IconPhotoScan, IconUserScan in category "System".
Reason: scary ghost and pumpkin jack nicely fit with "Games"(I guess).
Reason: scary ghost and pumpkin jack nicely fit with "Games"(I guess).
Reason: piano is sth. you can play with, pick is a symbolic item in Minecraft.
Reason: looks like toys to me(not sure about these two).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completed about 100 icons' missing category meta info.