Rename arguments #15
Open
Rename arguments #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
whyboris
commented
May 13, 2019
|
|
||
| if (Math.abs(thisLength - thatLength) > (limit || 100)){ |
There was a problem hiding this comment.
|
This PR makes quite a few changes, please let me know if you'd like me to undo any of them 👌 After you approve whichever changes should get merged, I'll update the CHANGELOG 😀 |
|
Hey, thanks! I havn't looked at the code yet, but from your comments it looks like a very welcome changes. I'm quite busy this week, but I promise to review as soon as I have some extra time. |
|
No worries -- and no rush 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
index.jsfile 👍vartoletandconst-- it's been enough years that it shouldn't cause trouble for anyone I think 😅