feat: add shared formula logic #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eliminate unwrap and return proper error
tafia
reviewed
Apr 15, 2024
src/xlsx/cells_reader.rs
Outdated
| } | ||
| if shared_index.is_some() && shared_ref.is_none() { | ||
| // shared formula | ||
| let cell_regex = Regex::new(r"[A-Z]+[0-9]+").unwrap(); |
There was a problem hiding this comment.
Please don't build regex in a loop.
tafia
reviewed
Apr 15, 2024
| if shared_ref.is_none() { | ||
| // shared formula | ||
| let cell_regex = | ||
| Regex::new(r"\b[A-Z]{1,3}\d+\b").unwrap(); |
|
close this PR for trying anoter concept. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #391 mentioned,
ftag can use shared formula which doesn't has real value.formula need to be calculated, and offset can either be in row or column.
In this PR,
load_shared_formuladoesn't applied, because it take a full scan of file.