Oom alloc #463
Open
Oom alloc #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Added another example that OOMs, hasn't been fixed yet, I'm working around it for my usecase by using unstable |
|
Thanks! |
|
Do you mean a comment explaining the last OOM file that was added? |
sftse
force-pushed
the
oom-alloc
branch
2 times, most recently
from
17fc324 to
1ffc325
Compare
|
I've added a FIXME to the function call that OOMs, if this was not what was meant please advise further. |
|
Curious whether you know anything about the unknown record types as mentioned in #462. |
When reading a PtgStr 2.5.198.89 the cch byte of ShortXLUnicodeString indicates the number of characters in the string. The error here is twofold: 1. The byte buffer holding the string characters in prematurely truncated before calling fn read_unicode_string_no_cch() based on cch, although the correct length in bytes can only be known inside fn read_unicode..() after checking the fHighByte flag. The fix is to not truncate the buffer at all pass it in its entirety so that fn read_unicode..() may decide how many bytes to read. 2. The second error then advances the offset into the buffer based on this erroneous length, which later leads to crashes.
…prevent OOM allocation due to overflow
…e, otherwise this will crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was it intentional that
fn from_sparseassumes cells are in(row, col)order? This test example demonstrates this is not always the case and OOM allocates due to an overflow.Based on #462restructured history