Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed format #479

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Malformed format #479

wants to merge 3 commits into from

Conversation

sftse
Copy link
Contributor

@sftse sftse commented Nov 12, 2024

No description provided.

@tafia
Copy link
Owner

tafia commented Nov 15, 2024

Hi do you mind writing a description of what was wrong exactly? I can read the code but it makes understanding high level issues better when they are written out.
Thanks

@sftse
Copy link
Contributor Author

sftse commented Nov 15, 2024

The code reads at least 5 bytes from the slice when parsing, but the error check only covers four, leading to a panic on r.data[4].
Since this is the only thing preventing the provided example case from parsing, continue when such errors are encountered.

This panic could be explained differently, if a defective record is passed to fn parse_format, but record parsing being correct seems so fundamental to understanding xls that it seemed unlikely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants