Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add flattened enum deserialization #738

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

Frankkkkk
Copy link
Contributor

Add a small example about flattened enum deserialization. This is a small workaround around serde's serde's
issue
.

Big thanks to @Mingun for (most) of the code + help!

@Mingun
Copy link
Collaborator

Mingun commented Apr 20, 2024

Thanks for the example. Need to fix lint issues and find a way to enable "serialize" feature for this example or just run it when that feature is active.

@Frankkkkk
Copy link
Contributor Author

Frankkkkk commented Apr 20, 2024

It should be fixed, sorry for the oversight. Cheers
EDIT: 🤦 sorry

examples/flattened_enum.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 64 lines in your changes are missing coverage. Please review.

Project coverage is 61.24%. Comparing base (29962e7) to head (c554ed1).
Report is 3 commits behind head on master.

Files Patch % Lines
examples/flattened_enum.rs 0.00% 64 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
- Coverage   61.48%   61.24%   -0.24%     
==========================================
  Files          38       39       +1     
  Lines       16213    16277      +64     
==========================================
+ Hits         9968     9969       +1     
- Misses       6245     6308      +63     
Flag Coverage Δ
unittests 61.24% <0.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mingun
Copy link
Collaborator

Mingun commented Apr 22, 2024

Forget to mention: could you add an entry to the Changelog.md about new example, so people will aware that it is exist? Remember, that changelog contains section with changes and list of link targets at the end of each chapter (== version). This is standard markdown way to split link usage and link target.

All everything is good.

@Frankkkkk
Copy link
Contributor Author

done. thanks

Add a small example about flattened enum deserialization. This is a
small workaround around serde's [serde's
issue](serde-rs/serde#1905).

Big thanks to @Mingun for (most) of the code + help!

Signed-off-by: Frank Villaro-Dixon <[email protected]>
@Mingun Mingun merged commit e8ae020 into tafia:master Apr 26, 2024
6 checks passed
@Mingun
Copy link
Collaborator

Mingun commented Apr 26, 2024

Thanks! I slightly improved text in changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants