-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BytesCData::escaped()
fn
#832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR. Some minor improvements can be made here and there, and also please add changelog entry. Use link to the issue #831 in section for issues and brief description about added method in New Features section. See the other issues in the file for an example.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #832 +/- ##
==========================================
+ Coverage 60.21% 60.23% +0.01%
==========================================
Files 41 41
Lines 16021 16029 +8
==========================================
+ Hits 9647 9655 +8
Misses 6374 6374
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thanks for the quick review. I just pushed a couple of commits and I think I addressed all of the comments :) |
939e320
to
18d9817
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. Only add changelog entry please.
done! |
In the end I actually rewrite the whole implementation to use |
This PR should resolve #831 by implementing an
escaped()
fn on theBytesCData
struct as suggested in #831 (comment).I opted for keeping the
new()
fn around and introducing another function instead because thenew()
fn is used in various places in thequick-xml
test suite and I didn't want to break anything. This should also allow us to ship this PR in a non-breaking version release since the existingnew()
fn keeps working as-is. We could consider deprecating thenew()
fn though to make it easier for users to understand that they should useescaped()
instead. We could also add araw()
fn as an alias fornew()
if we would like to keep the behavior for some users while still deprecatingnew()
.Related:
]]>
inCDATA
is not escaped #831]]>
inCDATA
is not escaped rust-syndication/rss#173]]>
escaping inCDATA
sections rust-syndication/rss#174/cc @Mingun