Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to_utf8_io_writer helper serializing into std::io::Write #836

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

pronebird
Copy link
Contributor

@pronebird pronebird commented Dec 29, 2024

This PR is related to #499 and adds a helper method to dump XML into std::io::Write restricted to utf-8 output. The name is a bit verbose trying to convey that a. it's utf-8 only b. it's io::Writer and not fmt::Write to avoid confusion

Copy link
Collaborator

@Mingun Mingun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a changelog entry under New Features? Do not forgot to add a link to PR, like other entries. All links placed at the end of corresponding version section (Unreleased in that case)

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.31%. Comparing base (a9391f3) to head (c0413a3).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
src/se/mod.rs 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
+ Coverage   60.21%   60.31%   +0.09%     
==========================================
  Files          41       41              
  Lines       16021    16002      -19     
==========================================
+ Hits         9647     9651       +4     
+ Misses       6374     6351      -23     
Flag Coverage Δ
unittests 60.31% <0.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pronebird
Copy link
Contributor Author

Could you also add a changelog entry under New Features? Do not forgot to add a link to PR, like other entries. All links placed at the end of corresponding version section (Unreleased in that case)

Sure thing. Done.

@Mingun Mingun merged commit 9ad2010 into tafia:master Dec 29, 2024
@pronebird pronebird deleted the utf8writer branch December 29, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants