Release 0.4.0-alpha.6 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
commented
Sep 1, 2019
| /// A struct generated by pin-project to provide an appropriate | ||
| /// `Unpin` implementation, this type's `Unpin` implementation | ||
| /// uses exactly the same conditions as the original type's | ||
| /// `Unpin` implementation. |
There was a problem hiding this comment.
I believe adding this will improve the generated documentation a little. (context: #53)
Structs
| PublicStruct | |
| __UnpinStructPublicStruct | A struct generated by pin-project to provide an appropriate
|
There was a problem hiding this comment.
(Perhaps we can improve the documentation and naming more.)
There was a problem hiding this comment.
@Aaron1011 @Nemo157 Any thoughts?
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 1, 2019
56: Release 0.4.0-alpha.6 r=taiki-e a=taiki-e Co-authored-by: Taiki Endo <[email protected]>
Build succeeded
|
bors bot
added a commit
that referenced
this pull request
Sep 3, 2019
62: Improve document of UnpinStruct r=Aaron1011 a=taiki-e Improve document and add a way to opt-out mentioned in #53 (comment). The reason for needing support for ways other than `-Zallow-features` is that it also affects the use of other dependency unstable features. Related: #54 #56 (comment) Generated document: <img width="1001" alt="struct-1" src="https://user-images.githubusercontent.com/43724913/64136451-95494280-ce2c-11e9-81ce-6a02c315332f.png"> <img width="1015" alt="struct-2" src="https://user-images.githubusercontent.com/43724913/64136462-a6924f00-ce2c-11e9-9d1c-3cdca2d9b158.png"> Ways to opt-out of this: https://github.com/taiki-e/pin-project/blob/5f7c6e35c2a9f3dfbc01a63e6206875d1bfb986b/pin-project-internal/build.rs#L21-L28 Co-authored-by: Taiki Endo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.