Change the argument type of project method back to self: Pin<&mut Self>
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
commented
Sep 16, 2019
| @@ -19,8 +19,7 @@ fn project_stmt_expr_nightly() { | |||
|
|
|||
| let mut baz = Baz::Variant1(1, 2); | |||
|
|
|||
| let mut baz = Pin::new(&mut baz); | |||
| let mut baz = baz.project(); | |||
| let mut baz = Pin::new(&mut baz).project(); | |||
There was a problem hiding this comment.
Well, this might be useful too.
taiki-e
commented
Sep 16, 2019
| @@ -295,30 +291,30 @@ fn lifetime_project() { | |||
|
|
|||
| impl<T, U> Struct<T, U> { | |||
| fn get_pin_mut<'a>(self: Pin<&'a mut Self>) -> Pin<&'a mut T> { | |||
| self.project_into().pinned | |||
| self.project().pinned | |||
There was a problem hiding this comment.
I didn't see this as a problem because I know both ways, but it would be easier to do all of this with a single method.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 18, 2019
90: Change the argument type of project method back to `self: Pin<&mut Self>` r=taiki-e a=taiki-e Closes #89 Co-authored-by: Taiki Endo <[email protected]>
Build failed
|
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Sep 18, 2019
90: Change the argument type of project method back to `self: Pin<&mut Self>` r=taiki-e a=taiki-e Closes #89 Co-authored-by: Taiki Endo <[email protected]>
Build succeeded
|
This was referenced Sep 18, 2019
Merged
bors bot
added a commit
that referenced
this pull request
Sep 22, 2019
101: Release 0.4.0-beta.1 r=taiki-e a=taiki-e Changes: * [Changed the argument type of project method back to `self: Pin<&mut Self>`.][90] * [Removed "project_attr" feature and always enable `#[project]` attribute.][94] * [Removed "renamed" feature.][100] * [`#[project]` attribute can now be used for `use` statements.][85] * [Added `project_ref` method and `#[project_ref]` attribute.][93] * [`#[pin_project]` attribute now determines the visibility of the projection type/method is based on the original type.][96] cc #21 [85]: #85 [90]: #90 [93]: #93 [94]: #94 [96]: #96 [100]: #100 Co-authored-by: Taiki Endo <[email protected]>
This was referenced Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #89