Remove dependency on postcss-functions #4317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes our dependency on
postcss-functions
by implementing the logic we need ourselves. The primary motivation for this is to be able to throw errors from the relevant node, instead of having to throw them from the root. Usingpostcss-functions
we had no way to access the actual node where the function was being called to throw a helpful error, but by implementing it ourselves we can make sure to keep a reference to the node and make it available to the actual function.