Remove outdated focus style fix #4780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4769.
This PR removes some styles we originally inherited from SUIT CSS Base that corrected a focus style bug in IE and Firefox where buttons with transparent backgrounds lost their focus styles. We no longer support IE at all, and this bug has since been corrected in Firefox, so removing this fix. Removing actually improves accessibility in Firefox since they have switched to a much more pronounced default focus style, whereas these old styles used a subtle dotted focus ring that is hard to see in many designs.
This has the added benefit of not automatically adding focus styles to buttons on click in Chromium-based browsers.