Fix pathname parsing for tracked files #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trackedModified call in the tracking logic has a bug that
incorrectly removes `null` from pathnames
Currently:
```
let pathname = parsed.href.replace(parsed.hash, '').replace(parsed.search, '')
```
Where if `parsed.hash` or `parsed.search` are missing (which is
mostly the case for FS files), the value is null
eg `{ hash: null, search: null}`
- In which case, we essentially trim `null`
converting `/mypath/nulldir/file.js` -> `/mypath/dir/filejs` and
breaking builds (see tailwindlabs#4920 ).
Fix checks if `hash` or `search` are set before replacing them
Fixes tailwindlabs#4920
|
Hey! Thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
trackModifiedcall in the tracking logic has a bug that incorrectly removesnullfrom pathnames when it tries to removehashorsearchvalues from the parsed path.Currently:
Where if
parsed.hashorparsed.searchare missing (which is mostly the case for FS files), the value is nulleg
{ hash: null, search: null}nullConverting
/mypath/nulldir/file.js->/mypath/dir/filejsand breaking builds (see JIT Build error #4920) or potentially accessing the wrong files.Fix checks if
hashorsearchare set before replacing themFixes #4920