Introduce support for APL-A #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APL-A is Alexa Presentation Language for audio effects. It is similar to APL in its structure (directives, data sources, documents etc.). However, it is different from APL in that there is no concept of supported interfaces. It is supported on all Alexa devices. In this commit, we add support for validating APLA directives and also added a test. I was divided on whether we should just add APL-A to existing APL validator or if we should create a compeltely independent validator for APL-A. For now I added it to the existing APLValidator but open to feedback. #20
shouldEndSession has a special meaning when it is undefined. It is usually used on APL devices to leave the visuals showing without opening up the mic. I modified most tests to explicity end the session. The touch handler test was written to leave the shouldEndSession in an undefined state to test the changes in this commit. https://developer.amazon.com/en-US/docs/alexa/custom-skills/manage-skill-session-and-session-attributes.html#screen-session
Documentation changes after adding support for shouldEndSession being undefined.
|
Some unrelated commits got in. Will submit again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Introduces support for APL-A
APL-A is Alexa Presentation Language for audio effects. It is similar to
APL in its structure (directives, data sources, documents etc.). However,
it is different from APL in that there is no concept of supported interfaces.
It is supported on all Alexa devices.
In this commit, we add support for validating APLA directives and also added
a test.
I was divided on whether we should just add APL-A to existing APL validator
or if we should create a compeltely independent validator for APL-A. For now
I added it to the existing APLValidator but open to feedback.
Support testing APLA directives #20