Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove legacy mongo #160

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

Thadoy
Copy link

@Thadoy Thadoy commented Jun 12, 2024

  • Please check if the PR fulfills these requirements
  • [*] The commit message describes your change
  • [*] Tests for the changes have been added if possible (for bug fixes / features)
  • [*] Docs have been added / updated (for bug fixes / features)
  • [*] Changes are mentioned in the changelog (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Tech update

  • What is the current behavior? (You can also link to an open issue here)
    Dvalin mongodb uses the mongodb-driver-legacy.

  • What is the new behavior (if this is a feature change)?
    Dvalin mongodb uses mongodb-driver-sync.
    The "new" Dvalin mongodb-legacy uses the mongodb-driver-legacy.

  • Does this PR introduce a breaking change? (What changes might users need to make in their setup due to this PR?)
    There are braking changes with dvalin mongodb. To limit the impact, the old code was duplicated in mongodb-legacy.

A user would have to change their mongodb import to mongodb-legacy, if the choose not to migrate to the new code.

  • Other information:

Felix Zwirn added 2 commits June 12, 2024 07:58
@YukiInu YukiInu merged commit b0355f6 into taimos:master Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants