Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvalin-jaxrs: Fix conflict between jetty ContextHandlers #171

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

marc92w
Copy link
Contributor

@marc92w marc92w commented Dec 3, 2024

  • Please check if the PR fulfills these requirements
  • The commit message describes your change
  • Tests for the changes have been added if possible (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Changes are mentioned in the changelog (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fix jetty ContextHandlers for web and static files being in conflict since Configurable dvalin-jaxrs #136

  • What is the current behavior? (You can also link to an open issue here)
    Files located under "./static/" block access to the web frontend.

  • What is the new behavior (if this is a feature change)?
    Frontend is served under / and static files are served under /static/ which restores behavior before migration of jetty.xml in Configurable dvalin-jaxrs #136

  • Does this PR introduce a breaking change? (What changes might users need to make in their setup due to this PR?)
    Not if you do not rely on static files being served under "/". If that's the case adjust urls to static files.

@marc92w marc92w marked this pull request as ready for review December 3, 2024 09:25
@YukiInu YukiInu merged commit 670c25b into taimos:master Dec 8, 2024
2 checks passed
@marc92w marc92w deleted the bugfix/jaxrs-static-files branch December 9, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants