-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perceptual Loss missing #9
Comments
To make the code more simpler So to load this model, we need the However, I will also make it possible to do with tensorflow. Thanks |
Hi, thanks for the fast reply. I saw that and I'm already working on a solution in tf only. |
Is it possible to PR? |
Yes, I'll send you a PR when I'm finished |
Thanks a lot. |
@taki0112 Hi, I think I managed to get perceptual loss to work, but I'm not 100% sure. Unfortunately I cannot create a PR, since I changed a couple of other things before. Please look at this commit. There is everything for perceptual loss. You can find the download links for the vgg16 weight files in vgg16.py on top in comment section. You can also look in this config file to see which values the arguments for the vgg part has. I only tested everything with the .h5 weight files. Another issue would be to implement LPIPS Distance also in TF. Do you have such intentions? It would be very good if you could look over the code, I'm not an expert in TF like you :) EDIT: this commit is also needed. |
@Cuky88 Hi. Сorrect me if I'm wrong. |
@MartinMeliss You are right, image floats are scaled between -1 and 1. So the vgg preprocessing is skrewing up everything. Thanks for pointing out, will fix soon. |
Thanks for your great work @taki0112
I'm curious why you didn't implement the perceptual loss, is there a special reason?
Cheers.
The text was updated successfully, but these errors were encountered: