Allow merge method to accept null as argument to prevent exception #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was something I came across while using this filter in conjunction with the Symfony UX Twig Components
https://symfony.com/bundles/ux-twig-component/current/index.html#cva-and-tailwind-css
I found that if I used the filter like this
attributes.render('class')|tailwind_merge
andrender('class')
ended up returningnull
it results in a crash.You can work around this by using null coalesce like
attributes.render('class') ?? ''|tailwind_merge
but this feels a bit cumbersome when using it in quite a few places throughout a component.It feels like simply allowing
null
as an accepted argument type and letting it return an empty string is sensible rather than throwing a type exception.Would be interested to know your thoughts on this. 🙂 Thanks!