-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for pugjs (previously known as jade) #239
Conversation
I wonder if its possible to use the existing jade files and mock them using the pug word. |
It should be quite simple to do that, I was a bit concerned about the dependencies - but it will definitively help in maintaining the tests in the future. Should we keep the |
I'd change them to *.pug and then point the jade tests/tasks at them so it is both backwards and forwards compatible |
Hmm... the problem is that the only thing different between the Consider this, it('should work with jade files (buffered comments)', testReplace('pug'));
it('should work with pug files (buffered comments)', testReplace('pug')); they do basically the same thing twice. The problem is not with the testReplace(..) function, but more to the fact that we want to test with I have the changes that remove the What do you think? |
I wonder if we can stub out the lookup by extension to trick it |
yo, when will to update the npm? i need pug |
+1 |
2 similar comments
+1 |
+1 |
As mentioned here, Jade was renamed to Pug. This also means that in the future,
*.jade
files will be renamed to*.pug
.This pull request contains the updates necessary to support
*.pug
files in the same way as*.jade
. Even though*.jade
files may be gone at some point, we will need to continue to support them as well in the future, for compatibility reasons.