Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for pugjs (previously known as jade) #239

Merged
merged 1 commit into from
Jun 7, 2016

Conversation

greyfocus
Copy link
Contributor

As mentioned here, Jade was renamed to Pug. This also means that in the future, *.jade files will be renamed to *.pug.

This pull request contains the updates necessary to support *.pug files in the same way as *.jade. Even though *.jade files may be gone at some point, we will need to continue to support them as well in the future, for compatibility reasons.

@eddiemonge
Copy link
Contributor

I wonder if its possible to use the existing jade files and mock them using the pug word.

@greyfocus
Copy link
Contributor Author

It should be quite simple to do that, I was a bit concerned about the dependencies - but it will definitively help in maintaining the tests in the future.

Should we keep the *.pug files though, since that will be the official name? In this case, we could change the jade tests to point to the *.pug fixtures.

@eddiemonge
Copy link
Contributor

I'd change them to *.pug and then point the jade tests/tasks at them so it is both backwards and forwards compatible

@greyfocus
Copy link
Contributor Author

Hmm... the problem is that the only thing different between the *.jade fixtures and the *.pug fixtures is the extension. Hence, if we remove the *.jade fixtures and point the tests to the *.pug ones, we will not have test coverage for *.jade files.

Consider this,

    it('should work with jade files (buffered comments)', testReplace('pug'));
    it('should work with pug files (buffered comments)', testReplace('pug'));

they do basically the same thing twice. The problem is not with the testReplace(..) function, but more to the fact that we want to test with *.jade files as well, since we use the file extension to figure out the format that we should use.

I have the changes that remove the *.jade fixtures completely and update the tests to use only *.pug files, but I'm not sure if we should include it.

What do you think?

@eddiemonge
Copy link
Contributor

I wonder if we can stub out the lookup by extension to trick it

@eddiemonge eddiemonge merged commit 0c247f9 into taptapship:master Jun 7, 2016
@patrikx3
Copy link

yo, when will to update the npm? i need pug

@p1tt1
Copy link

p1tt1 commented Nov 16, 2016

+1

2 similar comments
@fvena
Copy link

fvena commented Nov 29, 2016

+1

@zce
Copy link

zce commented May 16, 2017

+1

silvenon pushed a commit to yeoman/generator-webapp that referenced this pull request May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants