-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: global publish template, malleability fix, pub templates in wallet #1228
Merged
sdbondi
merged 7 commits into
tari-project:development
from
sdbondi:consensus-publish-template-globally
Jan 6, 2025
Merged
feat!: global publish template, malleability fix, pub templates in wallet #1228
sdbondi
merged 7 commits into
tari-project:development
from
sdbondi:consensus-publish-template-globally
Jan 6, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI)582 tests +10 582 ✅ +10 1h 28m 49s ⏱️ + 14m 4s Results for commit 889c4a2. ± Comparison against base commit 973f8a1. This pull request removes 4 and adds 14 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
sdbondi
force-pushed
the
consensus-publish-template-globally
branch
from
December 26, 2024 14:06
96571e7
to
20726d7
Compare
New bindings release required, so web components fail to build |
sdbondi
force-pushed
the
consensus-publish-template-globally
branch
2 times, most recently
from
December 31, 2024 13:56
5953bca
to
e4690b3
Compare
sdbondi
force-pushed
the
consensus-publish-template-globally
branch
from
December 31, 2024 14:09
e4690b3
to
bf61bb7
Compare
sdbondi
force-pushed
the
consensus-publish-template-globally
branch
from
December 31, 2024 14:10
bf61bb7
to
4eb2a22
Compare
sdbondi
force-pushed
the
consensus-publish-template-globally
branch
2 times, most recently
from
January 6, 2025 07:20
2ff2b96
to
cb440eb
Compare
sdbondi
force-pushed
the
consensus-publish-template-globally
branch
from
January 6, 2025 07:24
cb440eb
to
889c4a2
Compare
LGTM! utACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(transactions)!: fix transaction signatures malleability
feat(wallet): add support for publishing templates
feat(consensus): publish templates to all shards
feat(wallet): add UI for publishing templates
fix(consensus): correct input involvement info in evidence
Wallet daemon now has a transactions.publish_template JSON-RPC call
Motivation and Context
Currently all signatures but one could be surreptitiously removed from the transaction - this PR fixes this by allowing a pre-agreed signer to "seal" the transaction.
Wallet daemon now has a
transactions.publish_template
JSON-RPC call.Transactions containing publish template commands are considered "global" i.e. involve all shard groups.
This provides the following benefits:
Downside is the extra communication overhead of a global transaction
Next steps:
How Has This Been Tested?
Manually, publishing templates through the wallet UI on a multi-shardgroup network.
What process can a PR reviewer use to test or verify this change?
As above
Breaking Changes
BREAKING CHANGE: wire-protocol for transactions, database is not compatible, submit transaction JSON-RPC call is not backward-compatible.