Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge test helpers #212

Closed
marcelomorgado opened this issue Feb 24, 2019 · 1 comment
Closed

Merge test helpers #212

marcelomorgado opened this issue Feb 24, 2019 · 1 comment
Labels
tech debt Technical debt not involving bugs or features
Milestone

Comments

@marcelomorgado
Copy link
Contributor

@pcowgill commented:

I agree that now is a good moment for that. OpenZeppelin has a special repo for their test helpers, so maybe we could even make them their own child package to follow their example but with more of a monorepo style.

If we do want to keep them in an existing package, we can use this question to frame it: Do the test helpers end up being used more in unit tests or integration tests? Or a little of both?

If unit, maybe action. If integration, maybe tasit SDK. If mixture, probably a new child package.

And I agree that some helpers functions could be utils functions exposed from the SDK. And it would be great if put comments near them about that like you mentioned.

Refs: #207 (comment)

@marcelomorgado marcelomorgado added the tech debt Technical debt not involving bugs or features label Feb 24, 2019
@marcelomorgado marcelomorgado added this to the 0.2.0 release milestone Feb 24, 2019
@pcowgill
Copy link
Member

pcowgill commented Jul 7, 2020

This was closed by #496

@pcowgill pcowgill closed this as completed Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Technical debt not involving bugs or features
Projects
None yet
Development

No branches or pull requests

2 participants