Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gnosis Safe bootstrap #217

Merged
merged 49 commits into from
Feb 28, 2019
Merged

Gnosis Safe bootstrap #217

merged 49 commits into from
Feb 28, 2019

Conversation

marcelomorgado
Copy link
Contributor

@marcelomorgado marcelomorgado commented Feb 25, 2019 •
edited
Loading

Issue link

#216, #221

Auto-close the issue?

Closes #216, #212

Types of changes

New feature (non-breaking change that adds functionality)

Meta (a change that affects future changes to this repo)

Notes

Is the tasit-identity-contract the best place to put Gnosis Safe code?

@pcowgill pcowgill changed the title Feature/gnosis safe Gnosis Safe Feb 25, 2019
@pcowgill
Copy link
Member

@marcelomorgado Re: the Notes section:

Is the tasit-identity-contract the best place to put Gnosis Safe code?

I think tasit-identity-contract is the best place to put Gnosis Safe code related to adding the ephemeral account as a signer to the contract-based account and taking actions on behalf of that contract-based account.

I think tasit-link-wallet is the best place to put any Gnosis Safe code related to getting approval for the ephemeral account to spend ERC20 or ERC721 tokens on behalf of the Safe or for moving funds from the ephemeral account to the Safe.

Does that make sense?

@pcowgill pcowgill changed the title Gnosis Safe Gnosis safe Feb 25, 2019
@pcowgill pcowgill changed the title Gnosis safe Gnosis Safe Feb 25, 2019
@marcelomorgado
Copy link
Contributor Author

@marcelomorgado Re: the Notes section:

Is the tasit-identity-contract the best place to put Gnosis Safe code?

I think tasit-identity-contract is the best place to put Gnosis Safe code related to adding the ephemeral account as a signer to the contract-based account and taking actions on behalf of that contract-based account.

I think tasit-link-wallet is the best place to put any Gnosis Safe code related to getting approval for the ephemeral account to spend ERC20 or ERC721 tokens on behalf of the Safe or for moving funds from the ephemeral account to the Safe.

Does that make sense?

Yes!

@marcelomorgado marcelomorgado mentioned this pull request Feb 26, 2019
Open
@marcelomorgado marcelomorgado changed the title Gnosis Safe Gnosis Safe bootstrap Feb 27, 2019
pcowgill
pcowgill previously approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@pcowgill pcowgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcelomorgado Great work!

package.json Show resolved Hide resolved
packages/tasit-action/src/TasitAction.js Outdated Show resolved Hide resolved
packages/tasit-contracts/3rd-parties/gnosis/scripts/2_deploy_contracts.js Show resolved Hide resolved
packages/tasit-contracts/3rd-parties/gnosis/scripts/2_deploy_contracts.js Outdated Show resolved Hide resolved
packages/tasit-contracts/3rd-parties/gnosis/scripts/2_deploy_contracts.js Outdated Show resolved Hide resolved
packages/tasit-identity-contract/src/GnosisSafeUtils.js Outdated Show resolved Hide resolved
packages/tasit-identity-contract/src/GnosisSafeUtils.js Show resolved Hide resolved
packages/tasit-identity-contract/src/GnosisSafeUtils.js Outdated Show resolved Hide resolved
packages/tasit-identity-contract/src/GnosisSafeUtils.js Outdated Show resolved Hide resolved
packages/tasit-identity-contract/src/GnosisSafeUtils.js Show resolved Hide resolved
@marcelomorgado marcelomorgado mentioned this pull request Feb 28, 2019
Closed
pcowgill
pcowgill previously approved these changes Feb 28, 2019
View reviewed changes
packages/tasit-contracts/contracts/ERC20Detailed.sol Outdated Show resolved Hide resolved
packages/tasit-contracts/contracts/ERC721Full.sol Outdated Show resolved Hide resolved
packages/tasit-identity-contract/src/GnosisSafeUtils.js Show resolved Hide resolved
@marcelomorgado marcelomorgado mentioned this pull request Feb 28, 2019
Open
@pcowgill
Copy link
Member

@marcelomorgado Do any of the open threads gate merging?

@pcowgill pcowgill merged commit 46b10e9 into develop Feb 28, 2019
@marcelomorgado marcelomorgado mentioned this pull request Mar 1, 2019
Open
@pcowgill pcowgill deleted the feature/gnosis-safe branch March 5, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcowgill pcowgill pcowgill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gnosis Safe integration bootstrap
2 participants
@marcelomorgado @pcowgill