Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdentityContract > GnosisSafe: Create test case for transaction with insufficient signers #232

Closed
marcelomorgado opened this issue Feb 28, 2019 · 0 comments · Fixed by #254
Closed

IdentityContract > GnosisSafe: Create test case for transaction with insufficient signers #232

marcelomorgado opened this issue Feb 28, 2019 · 0 comments · Fixed by #254
Labels
tech debt Technical debt not involving bugs or features
Milestone
0.2.0 release

Comments

@marcelomorgado
Copy link
Contributor

marcelomorgado commented Feb 28, 2019 •
edited
Loading

Current Gnosis Safe test suite is testing a wallet with one signer.
Change that to have more than one signer and create a test case that sends a transaction with less signatures than the threshold.

Note: tasit-identity-contract will be renamed.

Refs: #217 (comment)
@marcelomorgado marcelomorgado added the tech debt Technical debt not involving bugs or features label Feb 28, 2019
@marcelomorgado marcelomorgado added this to the 0.2.0 release milestone Feb 28, 2019
@marcelomorgado marcelomorgado mentioned this issue Feb 28, 2019
Merged
@marcelomorgado marcelomorgado mentioned this issue Mar 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt Technical debt not involving bugs or features
Projects
None yet
Milestone
0.2.0 release
Development

Successfully merging a pull request may close this issue.

GnosisSafe insufficient signers testcase tasitlabs/tasit-sdk
1 participant
@marcelomorgado