Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GnosisSafe - Improve test cases #235

Open
marcelomorgado opened this issue Feb 28, 2019 · 1 comment
Open

GnosisSafe - Improve test cases #235

marcelomorgado opened this issue Feb 28, 2019 · 1 comment
Labels
tech debt Technical debt not involving bugs or features
Milestone
0.2.0 release

Comments

@marcelomorgado
Copy link
Contributor

Include gas consumption expectations on test cases comparing estimated gas calculated from GnosisSafe contract with gas spent on the transaction.
Note: Calculate gas used from sender account balances before and after the transaction.

Refs: #217 (comment)
@marcelomorgado marcelomorgado added the tech debt Technical debt not involving bugs or features label Feb 28, 2019
@marcelomorgado marcelomorgado added this to the 0.2.0 release milestone Feb 28, 2019
@marcelomorgado marcelomorgado mentioned this issue Feb 28, 2019
Merged
@marcelomorgado
Copy link
Contributor Author

Another improvement is doing the same assertion as GnosisSafe DailyModule test suite:

Withdrawal should fail because of ERC20 transfer revert
Withdrawal should fail because of ERC20 transfer out of gas
Withdrawal should fail because of ERC20 transfer returns false

@marcelomorgado marcelomorgado changed the title IdentityContracts > GnosisSafe - Gas usage assertion GnosisSafe - Improve test cases Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt Technical debt not involving bugs or features
Projects
None yet
Milestone
0.2.0 release
Development

No branches or pull requests
1 participant
@marcelomorgado