ESLint #379
Merged
ESLint #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interesting. Thanks for this info! |
pcowgill
approved these changes
May 3, 2019
There was a problem hiding this comment.
@marcelomorgado Nice work! I'm really liking all of these changes!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
#361
#329
#219
#237
Auto-close the issue?
Closes #361
Closes item 5 of #237
Types of changes
Technical debt (a code change that doesn't fix a bug or add a feature but makes something clearer for devs)
Notes
Lint scripts were moved to root otherwise, we'll have to install linter on all packages (Based on the discussion: lerna/lerna#2005).
I've realized that our scripts weren't using the
prettierbin from root repo but installing it vianpx.