Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strict mode: arguments -> args #7919

Closed
wants to merge 3 commits into from

Conversation

birkskyum
Copy link

@birkskyum birkskyum commented Sep 29, 2023

Currently, the cli breaks when running in strict mode, because a variable is named arguments which is a reserved word. I've renamed it to args. A similar change was recently applied to the create-tauri-app here. A user hitting this issue with the bun runtime can be found here.

  • Bugfix

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir
Copy link
Member

This has already been fixed and published, we will merge 1.x branch to dev later before publishing a new alpha version. Thanks for the contribution.

@amrbashir amrbashir closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📬Proposal
Development

Successfully merging this pull request may close these issues.

2 participants