Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update rust crate windows to 0.37.0 - autoclosed #484

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 6, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Type Update Change
windows dependencies minor 0.30.0 -> 0.37.0

Release Notes

microsoft/windows-rs

v0.37.0

Compare Source

This release includes a host of small improvements and fixes to the windows crate. Notably, changes to the implement and interface macros improve interoperability, correctness, and safety for COM and WinRT implementations.

This release does not include an update to the windows-sys crate, which remains stable and unchanged.

What's Changed

New Contributors

Full Changelog: microsoft/windows-rs@0.36.1...0.37.0

v0.36.1

Compare Source

This is a minor service release to work around docs.rs limitations in order to publish windows-sys docs.

What's Changed

New Contributors

Full Changelog: microsoft/windows-rs@0.36.0...0.36.1

v0.36.0

Compare Source

What's Changed

New Contributors

Full Changelog: microsoft/windows-rs@0.35.0...0.36.0

v0.35.0

Compare Source

What's Changed

Full Changelog: microsoft/windows-rs@0.34.0...0.35.0

v0.34.0

Compare Source

What's Changed

New Contributors

Full Changelog: microsoft/windows-rs@0.33.0...0.34.0

v0.33.0

Compare Source

What's Changed

Full Changelog: microsoft/windows-rs@0.32.0...0.33.0

v0.32.0

Compare Source

What's Changed

New Contributors

Full Changelog: microsoft/windows-rs@0.30.0...0.32.0

v0.31.0

Compare Source


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner February 6, 2022 13:03
@wravery
Copy link
Contributor

wravery commented Feb 6, 2022

I tried this with webview2-com, and I think there are a couple of changes to the implement macro that block upgrading to windows 0.32.0:

  • The implement macro has been reimplemented and moved to a new windows-implement crate (easy to fix).
  • It uses a nightly feature, so you can't build it with stable right now (a blocker IMO).
  • The code generator does not seem to emit all of the associated functions on the ..._Vtbl structs which are required by the macro (missing new and matches). This may require a new option passed to the generator, or it may just be a bug in the windows-bindgen crate.

@wravery
Copy link
Contributor

wravery commented Feb 6, 2022

BTW, there was no 0.31.0. Apparently that was published by mistake against an orphaned commit.

@renovate renovate bot force-pushed the renovate/windows-0.x branch 3 times, most recently from 7aeb3f8 to 7e91621 Compare February 15, 2022 05:10
@renovate renovate bot force-pushed the renovate/windows-0.x branch 3 times, most recently from f6d546e to b34cf92 Compare February 20, 2022 17:37
@renovate renovate bot changed the title fix(deps): update rust crate windows to 0.32.0 fix(deps): update rust crate windows to 0.33.0 Feb 24, 2022
@renovate renovate bot force-pushed the renovate/windows-0.x branch 5 times, most recently from bb5b50c to 6d5bb47 Compare March 3, 2022 04:59
@renovate renovate bot force-pushed the renovate/windows-0.x branch from 6d5bb47 to a662837 Compare March 4, 2022 03:37
@wravery
Copy link
Contributor

wravery commented Mar 5, 2022

This is currently blocked by microsoft/windows-rs#1523, which depends on either building with the nightly toolchain or waiting for 1.61 stable (and then removing the explicit #[feature] attributes which unblock it in nightly).

I have a version of webview2-com ready to go as well, but it is also blocked on that issue for now.

@renovate renovate bot force-pushed the renovate/windows-0.x branch from a662837 to afa85e4 Compare March 10, 2022 14:11
@renovate renovate bot changed the title fix(deps): update rust crate windows to 0.33.0 fix(deps): update rust crate windows to 0.34.0 Mar 15, 2022
@renovate renovate bot force-pushed the renovate/windows-0.x branch 2 times, most recently from 0e71c0d to 139ee60 Compare March 18, 2022 05:13
@renovate renovate bot force-pushed the renovate/windows-0.x branch 7 times, most recently from 20d4350 to 0da7f99 Compare April 3, 2022 13:40
@renovate renovate bot changed the title fix(deps): update rust crate windows to 0.34.0 fix(deps): update rust crate windows to 0.35.0 Apr 5, 2022
@renovate renovate bot force-pushed the renovate/windows-0.x branch from e8112dc to 61ce4e0 Compare April 11, 2022 01:10
@renovate renovate bot force-pushed the renovate/windows-0.x branch 4 times, most recently from 2033ba0 to 422e3ff Compare April 25, 2022 06:44
@renovate renovate bot changed the title fix(deps): update rust crate windows to 0.35.0 fix(deps): update rust crate windows to 0.36.0 Apr 26, 2022
@renovate renovate bot force-pushed the renovate/windows-0.x branch 2 times, most recently from 8b894ff to ccdc9db Compare April 27, 2022 00:58
@renovate renovate bot changed the title fix(deps): update rust crate windows to 0.36.0 fix(deps): update rust crate windows to 0.36.1 Apr 27, 2022
@renovate renovate bot force-pushed the renovate/windows-0.x branch 7 times, most recently from bfb3a52 to dd64aba Compare May 4, 2022 15:56
@renovate renovate bot force-pushed the renovate/windows-0.x branch 6 times, most recently from b27dd68 to df65f17 Compare May 10, 2022 14:15
@renovate renovate bot force-pushed the renovate/windows-0.x branch 2 times, most recently from 58dde40 to 9cc431f Compare May 19, 2022 15:48
@renovate renovate bot changed the title fix(deps): update rust crate windows to 0.36.1 fix(deps): update rust crate windows to 0.37.0 May 19, 2022
@renovate renovate bot force-pushed the renovate/windows-0.x branch from 9cc431f to 4d4e686 Compare May 20, 2022 11:50
@renovate renovate bot changed the title fix(deps): update rust crate windows to 0.37.0 fix(deps): update rust crate windows to 0.37.0 - autoclosed May 24, 2022
@renovate renovate bot closed this May 24, 2022
@renovate renovate bot deleted the renovate/windows-0.x branch May 24, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants