Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use consistent wording for checking types of completions #2644

Closed
bakkot opened this issue Jan 31, 2022 · 1 comment
Closed

use consistent wording for checking types of completions #2644

bakkot opened this issue Jan 31, 2022 · 1 comment
Labels
completion records Relates to completion records, and ? / ! notation. editorial change establishes editorial conventions

Comments

@bakkot
Copy link
Contributor

bakkot commented Jan 31, 2022

Some places we say "is an abrupt completion", some places we check the [[Type]] slot explicitly. Probably better to use the "is an X completion" wording throughout, since it reads nicer.
@bakkot bakkot added editorial change completion records Relates to completion records, and ? / ! notation. labels Jan 31, 2022
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Sep 4, 2023
@jmdyck
Editorial: Use "is a foo completion" instead of testing [[Type]] field
d954fc8 
Mostly, change:
    _x_.[[Type]] is ~foo~
to:
    _x_ is a foo completion

Resolves issue tc39#2644.
@jmdyck jmdyck mentioned this issue Sep 4, 2023
Merged
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Sep 21, 2023
@jmdyck
Editorial: Use "is a foo completion" instead of testing [[Type]] field
0f5b21f 
Mostly, change:
    _x_.[[Type]] is ~foo~
to:
    _x_ is a foo completion

Resolves issue tc39#2644.
jmdyck added a commit to jmdyck/ecma262 that referenced this issue Oct 13, 2023
@jmdyck
Editorial: Use "is a foo completion" instead of testing [[Type]] field
cdefa95 
Mostly, change:
    _x_.[[Type]] is ~foo~
to:
    _x_ is a foo completion

Resolves issue tc39#2644.
ljharb pushed a commit to jmdyck/ecma262 that referenced this issue Nov 3, 2023
@jmdyck @ljharb
Editorial: Use "is a foo completion" instead of testing [[Type]] field
b82d540 
Mostly, change:
    _x_.[[Type]] is ~foo~
to:
    _x_ is a foo completion

Resolves issue tc39#2644.
ljharb pushed a commit to jmdyck/ecma262 that referenced this issue Jan 10, 2024
@jmdyck @ljharb
Editorial: Use "is a foo completion" instead of testing [[Type]] field (
c7560a5 
tc39#3163)

Mostly, change:
    _x_.[[Type]] is ~foo~
to:
    _x_ is a foo completion

Resolves issue tc39#2644.
@michaelficarra
Copy link
Member

Fixed by #3163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completion records Relates to completion records, and ? / ! notation. editorial change establishes editorial conventions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelficarra @bakkot