Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent spacing around binary operators #925

Closed
domenic opened this issue May 30, 2017 · 5 comments
Closed

Inconsistent spacing around binary operators #925

domenic opened this issue May 30, 2017 · 5 comments

Comments

@domenic
Copy link
Member

domenic commented May 30, 2017

Mostly there seems to be space between binary operators and their operands, e.g. Repeat, while q ≠ s, If e = p, etc. But sometimes there is no spacing, e.g. the latter half of If e = p, let q be q+1, or the former half of If q+r > s.

Obviously very minor, but I think cleaning this up to add spaces everywhere would be good.

@code4cake
Copy link

hey guys, could I work on this issue, is this a good issue for a first-time contributor or should I take something else? Thanks

@littledan
Copy link
Member

@dantesolis Go for it! I think an editorial patch like this would be great for a first-time contributor. You can do this by editing the spec.html file in this repository and making a PR on GitHub. Feel free to ask questions here or on the #tc39 channel on Freenode IRC.

@ljharb
Copy link
Member

ljharb commented Mar 21, 2018

@dantesolis are you still hoping to take this on?

@jmdyck
Copy link
Collaborator

jmdyck commented Mar 22, 2018

If not, I'll do it.

@littledan
Copy link
Member

@jmdyck Go for it. I also ran into this in the mathematical values change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants