-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc editorial #1053
Merged
Merged
Misc editorial #1053
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
8df2809
Editorial: add more lookahead-restrictions to NotEscapeSequence
jmdyck c564154
Editorial: insert missing </emu-eqn>
jmdyck dbf7751
Editorial: delete extraneous dot
jmdyck cf8c857
Editorial: delete extra spaces and add a dot
jmdyck d7f1c6c
Editorial: add '*' around 'true' and 'false'
jmdyck 12dc570
Editorial: fix typo "algorthm"
jmdyck 0f1d570
Editorial: resolve "LocalTimeZoneAdjustment" vs "LocalTZA" inconsistency
jmdyck ec1cd8c
Editorial: Remove '_' RHS for IdentifierPart
jmdyck b4081da
Editorial: entity-encode < and >
jmdyck 0e04451
Editorial: tweak some indentation
jmdyck 342fdb0
Editorial: consistify grammar params in defining prodns
jmdyck 3c8d7fc
Editorial: elide unnecessary grammar params in non-defining prodns
jmdyck 7c9b35e
Editorial: fix mentions of Atom :: `(` Disjunction `)`
jmdyck 0a3b5a8
Editorial: "enclosing RegExp" -> "enclosing |Pattern|"
jmdyck 2ac876f
Editorial: insert hyphen in "left-capturing"
jmdyck 076284d
Editorial: "Otherwise" -> "Else"
jmdyck 22e7117
Editorial: move the paren before "U+003E" to after
jmdyck 1f2d1cb
Editorial: invert "Let the enclosed substring be _groupName_"
jmdyck c478751
Editorial: recap "left-capturing parentheses" more concisely.
jmdyck 9a455bc
Editorial: delete "this following"
jmdyck 63b6d27
Editorial: move StringValue-for-RegExpIdentifierName clause
jmdyck 956e094
Editorial: move BackreferenceMatcher to a more appropriate location
jmdyck 577f76f
Editorial: "Abstract Operation" -> "( _n_ )" in header
jmdyck f5cddb2
Editorial: add _namedCaptures_ parameter to GetSubstitution()
jmdyck 7b2fe11
Editorial: "|Term|" -> "the located |GroupSpecifier|"
jmdyck 261bc18
Editorial: "Let" -> "Set" for already-bound metavariable
jmdyck a1f915b
Editorial: remove `_` RHS from RegExpIdentifierPart
jmdyck f09e801
Editorial: tweak indentation
jmdyck 35ab8d5
Editorial: move PromiseResolve clause into Promise.resolve clause
jmdyck feaa751
Editorial: add "then" to "If" step
jmdyck cd12b08
Markup: entity-encode “ and ”
jmdyck 57b25af
Editorial: right-single-quotation-mark -> apostrophe twice
jmdyck f2ed860
Markup: <emu-nt>Foo</emu-nt> -> |Foo|
jmdyck 0fc5f71
Editorial: Add [?U] to RHS occurrences of CharacterClassEscape
jmdyck 2ad9c5f
Editorial: delete extraneous backslashes
jmdyck 2a7bb57
Editorial: `General_Category` -> “General_Category”
jmdyck 6a5870c
Editorial: |True| -> “True”
jmdyck 392b8d9
Editorial: move a sentence about property values
jmdyck 607e7d1
Editorial: tighten up the "must support/must not support" wording
jmdyck 9a4fa7a
Editorial: Put algorithm before supporting tables
jmdyck e3d9eff
Editorial: reorder UnicodePropertyValueExpression-related prodns
jmdyck 0d79be5
Editorial: tweak UnicodePropertyValueExpression eval algs
jmdyck b756cef
Editorial: avoid reusing/overwriting metavariable _p_
jmdyck d26d24a
Editorial: misc tweaks re lookbehind assertions
jmdyck 6e04f06
Editorial: add _direction_ to BackreferenceMatcher's param list
jmdyck 03bd376
Markup: fix well-formedness error
jmdyck 17da467
Markup: tweak note re parsing the same String multiple times.
jmdyck 528eb61
Markup: insert <p>...</p> tags
jmdyck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the intention here was less than or equal to. While gte/lte are not entities,
≤=
would preserve the intent. Is < a better assert? /cc @littledanThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never mind I don't know HTML entities.