Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: FlagText allows s #1123

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Normative: FlagText allows s #1123

merged 1 commit into from
Apr 19, 2018

Conversation

mysticatea
Copy link
Contributor

This PR fixes an oversight.

12.2.8.1 Static Semantics: Early Errors disallows s flag currently. But it should allow s flag since #1028.

@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text spec bug labels Feb 28, 2018
@ljharb ljharb requested review from bterlson and bmeck February 28, 2018 15:59
@bmeck
Copy link
Member

bmeck commented Feb 28, 2018

+1 matches RegExpInitialize if anyone was looking for the constructor / compile corollary.

@littledan
Copy link
Member

Please mark this PR as Normative: rather than Editorial:, as it fixes a bug and changes semantics.

@ljharb ljharb changed the title Editorial: FlagText allows s Normative: FlagText allows s Feb 28, 2018
@mysticatea
Copy link
Contributor Author

Thank you. I updated the commit message.

@ljharb ljharb assigned bterlson and unassigned mysticatea Feb 28, 2018
@littledan
Copy link
Member

This patch looks ready to land to me. Great work, @mysticatea ! What do you think, @bterlson ?

@bterlson
Copy link
Member

Looks good. I will also move this over to 2018 as it's just a simple bug fix :)

@bterlson bterlson merged commit 59d73dc into tc39:master Apr 19, 2018
@mysticatea mysticatea deleted the s-flag branch April 22, 2018 09:53
@ljharb ljharb mentioned this pull request May 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmeck bmeck bmeck approved these changes

@littledan littledan littledan approved these changes

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@ljharb ljharb ljharb approved these changes

@bterlson bterlson Awaiting requested review from bterlson

Assignees

@bterlson bterlson

Labels
normative change Affects behavior required to correctly evaluate some ECMAScript source text spec bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mysticatea @bmeck @littledan @bterlson @ljharb @mathiasbynens