Editorial: fix section IDs for some async generator sections. #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
editorial change
rendering bug
|
Ooof good catch. |
|
Seems good to merge, no? |
|
Might also be worth filing an issue on Ecmarkup to add duplicate-ID detection |
ljharb
force-pushed
the
fix_async_gen_ids
branch
2 times, most recently
from
10771e1 to
60d755a
Compare
domenic
approved these changes
Apr 20, 2018
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
May 14, 2018
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1140.
This appears to have been a copy-paste artifact from adding async generators.
Most of the existing ones have "async-generator", very few have "asyncgenerator", so I went with the (nicer) hyphenated variant.