Editorial: LocalTZA input specification #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaprocki
force-pushed
the
localtza-editorial
branch
from
35eb0d7 to
cd64b37
Compare
littledan
approved these changes
Apr 14, 2018
|
This PR has the @anba seal of approval #1070 (comment) |
ljharb
approved these changes
Jul 7, 2018
ljharb
requested review from
zenparsing and
a team
and removed request for
bterlson
|
Ping @tc39/ecma262-editors, noticed this is still pending |
ljharb
force-pushed
the
localtza-editorial
branch
from
e030921 to
c20a1e7
Compare
The `LocalTZA` implementation-defined algorithm must accept the full range of `Number` and not define its input to be a *time value* because the algorithm is specified to take an already offset local time that can be outside of the time value range. This cleans up the specification text to clearly distinguish UTC time values versus local time `Number` inputs and uses the same subscript notation for both UTC and local time to make the text more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LocalTZAimplementation-defined algorithm must accept the fullrange of
Numberand not define its input to be a time value becausethe algorithm is specified to take an already offset local time that can
be outside of the time value range.
This cleans up the specification text to clearly distinguish UTC time
values versus local time
Numberinputs and uses the same subscriptnotation for both UTC and local time to make the text more clear.
Fixes #1070