Editorial: parseFloat/parseInt: fix unintentional normative change from #1602
#1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
reviewed
Jul 18, 2019
|
BTW, the bug was with |
|
This is a nice caught and fix. I appreciate the work done here! |
ljharb
commented
Jul 18, 2019
ljharb
force-pushed
the
trim_string_redux
branch
from
dc8a979 to
4661220
Compare
zenparsing
approved these changes
Jul 18, 2019
leobalter
suggested changes
Jul 18, 2019
ljharb
force-pushed
the
trim_string_redux
branch
from
4661220 to
503ff83
Compare
devsnek
approved these changes
Jul 19, 2019
leobalter
approved these changes
Jul 19, 2019
ljharb
force-pushed
the
trim_string_redux
branch
from
503ff83 to
a68d129
Compare
ljharb
changed the title
parseFloat/parseInt: fix unintentional normative change from #1629parseFloat/parseInt: fix unintentional normative change from #1602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @devsnek for discovering.