Editorial: Add missing _direction_ parameter in extended regexp pattern evaluate semantics in annex b #1675
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdyck
approved these changes
Aug 21, 2019
ljharb
approved these changes
Aug 21, 2019
michaelficarra
approved these changes
Nov 9, 2019
ljharb
requested review from
syg and
bakkot
and removed request for
zenparsing and
a team
…rn evaluate semantics in Annex B (tc39#1675) Bugfix: When speccing lookbehind assertions (PR tc39#1029), a `direction` parameter were added, in particular to the `evaluate` semantics of Atom productions and to the CharacterSetMatcher abstract operation. The ExtendedAtom productions found in Annex B were forgotten to be amended in the same way. Fixes tc39#1674.
ljharb
force-pushed
the
annex-b-regexp-missing-direction-parameter
branch
from
d46d5de to
d12a7b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple bugfix. When lookbehind assertions were introduced (PR #1029), a direction parameter was added in the evaluate semantics of some productions of the RegExp grammar. Additional productions found in Annex B were overlooked.
Fixes #1674.