Editorial: quick fixes #1778
Merged
Editorial: quick fixes #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelficarra
approved these changes
Nov 14, 2019
ljharb
approved these changes
Nov 14, 2019
|
We've got to start writing down style conventions at some point. |
|
I'm still hoping we can find some kind of linter :-) |
|
I'm a fan of linters, but we'd need to start by writing down the current style conventions even if we had one. |
|
True enough - https://tc39.es/ecma262/#sec-notational-conventions is begging to be fleshed out. |
|
Note that writing down style conventions wouldn't have prevented the problems addressed by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple quick fixes for one of today's merges.