-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: normalisation around List construction #2142
Conversation
spec.html
Outdated
@@ -32600,11 +32600,11 @@ <h1>Atom</h1> | |||
1. Let _ye_ be _y_'s _endIndex_. | |||
1. If _direction_ is equal to +1, then | |||
1. Assert: _xe_ ≤ _ye_. | |||
1. Let _s_ be a new List whose elements are the characters of _Input_ at indices _xe_ (inclusive) through _ye_ (exclusive). | |||
1. Let _s_ be a List whose elements are the characters of _Input_ at indices _xe_ (inclusive) through _ye_ (exclusive). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Let _s_ be a List whose elements are the characters of _Input_ at indices _xe_ (inclusive) through _ye_ (exclusive). | |
1. Let _s_ be a List containing the characters of _Input_ at indices _xe_ (inclusive) through _ye_ (exclusive). |
Or perhaps better, replace all the potentially ambiguous "List containing..." text with "List whose elements are...".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should try to normalise that phrasing everywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I can do that as a follow-up PR. I also prefer "whose elements are".
ebbf3ab
to
d8902ff
Compare
There's still 29 uses of "a new List". I see those are all single-item lists. Did you intentionally skip those? For single-element lists, we use all of:
I would like those to get normalized as well, though I guess it need not be in this PR. My preference for these cases is to say "a List whose sole element is |
For single-element lists, there's also one occurrence of:
(Note "item" not "element".) |
@bakkot There's also hundreds of list literals using double angle brackets.
We can address this inconsistency in a follow-up PR. |
cb58c3d
to
aa85331
Compare
No description provided.