-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: add normative optional styling css override #2215
Conversation
We should be explicit about what the unit of optionality is. @codehag Could you add a sentence explicitly defining the unit of optionality to be everything within a Normative Optional colored box? |
53e6738
to
8b9a5fb
Compare
let me know if that is what you had in mind... Also, were there any thoughts about the point @erights raised about this needing to be visible even without css, or is this not likely to be an issue? One suggestion I can think of is that any section (ie 2.1 here) is followed by "Optional" or something to this effect. Then we can drop the prepend text from the css? |
We were thinking that ecmarkup can insert the full “normative optional” text explicitly. |
I applied the changes manually. github seems to have some issues applying comment suggestions atm. |
That feature has never worked right for this repo, something to do with permissions like if the suggester has write access or something, it breaks. I also find that suggestions generate these unreadable emails since the spec source has very long lines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This WFM for now. When we get ecmarkup generating the "normative optional" text for these sections, we can remove the :before
pseudo-element selector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I'll upstream the CSS into ecmarkup at some point.
I'm not quite used to the work flow: do I merge after 3 approvals, or do you? Or do we need one more? |
@codehag We will handle it. |
b0e42f1
to
31f3c2b
Compare
This addresses the problem brought up in #2214 -- where the styles for normative optional changes were forgotten (by me) when the weakrefs merge pr was made.
This likely isn't the best way to do this. This pr is here in case we need a stop gap solution until we clarify how best to add these styles in an accessible way. cc @bterlson, @ljharb, @michaelficarra, @syg and @bakkot.