Editorial: Merge the RHSs of AsyncFunctionExpression #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmdyck
force-pushed
the
AsyncFunctionExpression
branch
from
7eccfd8 to
42b9b1f
Compare
|
(force-pushed to resolve merge conflicts) |
bakkot
approved these changes
Jan 16, 2021
ljharb
approved these changes
Jan 16, 2021
michaelficarra
approved these changes
Jan 19, 2021
bakkot
added
the
ready to merge
The nonterminals: - FunctionExpression - ClassExpression - GeneratorExpression - AsyncGeneratorExpression are all defined with a single RHS involving an optional BindingIdentifier. But AsyncFunctionExpression is defined with two RHSs, one with a BindingIdentifier and one without. (It's been that way since it was introduced in PR tc39#692) I can't see any reason for it to be not like the others.
ljharb
force-pushed
the
AsyncFunctionExpression
branch
from
42b9b1f to
7dab950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nonterminals:
are all defined with a single RHS involving an optional BindingIdentifier.
But AsyncFunctionExpression is defined with two RHSs, one with a BindingIdentifier and one without. (It's been that way since it was introduced in PR #692.) I can't see any reason for it to be not like the others.