Editorial: remove unnecessary assertion #2296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's consistent with this comment in PR #545, which proposes that:
|
michaelficarra
approved these changes
Feb 8, 2021
syg
approved these changes
Feb 11, 2021
ljharb
added
the
ready to merge
Both S and R are Strings, so either both or neither should be asserted in the steps. I chose neither.
ljharb
force-pushed
the
extra-assertion
branch
from
bee2214 to
97c2b87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both S and R are Strings, and both are asserted in the prose, so either both or neither should be asserted in the steps. I chose neither.