Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: fix note about var decls in eval in parameter initializers #2428

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Jun 6, 2021

As pointed out here, this note in PerformEval no longer reflects the specified behavior, which changed in #1046.

@loganfsmyth
Copy link
Contributor

The SO question also mentions https://262.ecma-international.org/#sec-functiondeclarationinstantiation which has a note

Note 3

Parameter Initializers may contain direct eval expressions. Any top level declarations of such evals are only visible to the eval code (10.2). The creation of the environment for such declarations is described in 14.1.22.

which also looks incorrect.

@bakkot
Copy link
Contributor Author

bakkot commented Jun 6, 2021

Good catch, updated.

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jun 8, 2021
@ljharb ljharb merged commit 28fb25e into master Jun 9, 2021
@ljharb ljharb deleted the fix-eval-note branch June 9, 2021 16:51
mathiasbynens pushed a commit to mathiasbynens/ecma262 that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants