Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: don't imply that SV, TV, and TRV are shorthands #2451

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

michaelficarra
Copy link
Member

This was split out from #2435. I took issue with the way the usage of parentheses here implied that we were defining terms that were interchangeable (for example, wherever you use TV you may replace it with Template Value, and vice versa). In the process of removing these, I believe I also simplified the descriptions of the SDOs to get more to the point with less clutter.

@michaelficarra michaelficarra requested a review from a team July 7, 2021 20:13
@michaelficarra michaelficarra force-pushed the sv-tv-trv-are-not-replaceable branch from ae8e859 to 17e41d3 Compare July 9, 2021 14:47
@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Jul 15, 2021
@michaelficarra michaelficarra removed the editor call to be discussed in the next editor call label Jul 21, 2021
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@michaelficarra michaelficarra assigned bakkot and unassigned syg Jul 22, 2021
@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jul 22, 2021
@ljharb ljharb force-pushed the sv-tv-trv-are-not-replaceable branch from a808e70 to aa948ec Compare July 22, 2021 05:08
@ljharb ljharb merged commit aa948ec into master Jul 22, 2021
@ljharb ljharb deleted the sv-tv-trv-are-not-replaceable branch July 22, 2021 05:13
mathiasbynens pushed a commit to mathiasbynens/ecma262 that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants