Editorial: Refactor TemplateStrings SDO #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
approved these changes
Sep 5, 2022
|
Hmm. Might be worth it... |
|
If you're inclined to do that refactoring, I wouldn't say no to it. |
|
Is this what you had in mind? I think it's an improvement, but it's debatable. There's 3 different places where the
Currently I'm doing the middle one. Do you have a preference? |
|
Yup, that's what I had in mind, and yes, I think putting the list wrapping around each invocation is the way to go. |
michaelficarra
approved these changes
Sep 6, 2022
jmdyck
force-pushed
the
TemplateStrings_refactor
branch
from
6470245 to
313acd4
Compare
|
(force-pushed to take a more logical path to the same endpoint) |
syg
added
the
ready to merge
jmdyck
force-pushed
the
TemplateStrings_refactor
branch
from
313acd4 to
778890b
Compare
|
(force-pushed to squash 3 commits down to 1) |
(1)
Factor out new AO TemplateString.
(2)
Move `« ... »` from the list-concatenation step
to instead surround the call to TemplateString.
(3)
Do some simple inlining, from:
1. Let _x_ be TemplateString(|Y|, _raw_).
1. Return « _x_ ».
to:
1. Return « TemplateString(|Y|, _raw_) ».
ljharb
force-pushed
the
TemplateStrings_refactor
branch
from
778890b to
415600f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to separately handle
This separates all the
_raw_/TV/TRVstuff from the list-concatenation stuff, which I think makes it easier to see what's going on.(I don't think GitHub's diff is very helpful for this one.)