Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: String.prototype.normalize references the Unicode Standard instead of Annex 15 #3051

Merged
merged 1 commit into from
May 11, 2023

Conversation

dewren99
Copy link
Contributor

Changed the reference String.prototype.normalize is using as per #912

Please let me know if any further changes are needed, thanks!

image

@mathiasbynens
Copy link
Member

Since #620 the ECMAScript spec refers to the latest available Unicode version rather than any particular version. We could accomplish this here by changing the link to https://www.unicode.org/versions/latest/ch03.pdf and updating the text accordingly.

@dewren99
Copy link
Contributor Author

Updated the link and the text to refer to the latest Unicode Standard. I wasn't sure what would be the best text to represent the changes, let me know if you would prefer to use another specific text to display.

@dewren99
Copy link
Contributor Author

@mathiasbynens Also would it be better to not mention the section number 3.11? I'm not sure if the section numbering would kept the same in future versions.

@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label May 1, 2023
@michaelficarra
Copy link
Member

@dewren99 We discussed this in the editor call today. Let's drop the section number and only refer to the section by its name.

@michaelficarra michaelficarra removed the editor call to be discussed in the next editor call label May 3, 2023
@dewren99
Copy link
Contributor Author

dewren99 commented May 4, 2023

@michaelficarra Should I be keeping this branch up to date with the main until it's merged? I'm not sure what the preferred method is for this repo

@ljharb
Copy link
Member

ljharb commented May 4, 2023

@dewren99 if there's no conflicts, you shouldn't need to, as I'll rebase it before it lands as a matter of course. Feel free to rebase it yourself as you like, though.

@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label May 10, 2023
ljharb pushed a commit to dewren99/ecma262 that referenced this pull request May 10, 2023
@ljharb

This comment was marked as resolved.

@dewren99

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants