Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Clarify RegExp grammar parameter N → NamedCaptureGroups #3120

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Editorial: Clarify RegExp grammar parameter N → NamedCaptureGroups #3120

merged 1 commit into from
Aug 16, 2023

Conversation

mathiasbynens
Copy link
Member

This makes the parameter more easily searchable while clarifying its meaning.

Issue: #2411

@mathiasbynens mathiasbynens force-pushed the N-to-WithNamedCaptureGroups branch from bc45ce8 to a7c69b2 Compare July 12, 2023 07:15
@mathiasbynens mathiasbynens mentioned this pull request Jul 12, 2023
Open
@michaelficarra
Copy link
Member

I would probably drop With. They're all "with".

@mathiasbynens mathiasbynens force-pushed the N-to-WithNamedCaptureGroups branch from a7c69b2 to 2390fb4 Compare August 2, 2023 07:30
@mathiasbynens mathiasbynens changed the title Editorial: Clarify RegExp grammar parameter N → WithNamedCaptureGroups Editorial: Clarify RegExp grammar parameter N → NamedCaptureGroups Aug 2, 2023
@mathiasbynens
Copy link
Member Author

I would probably drop With. They're all "with".

Done

@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Aug 16, 2023
@mathiasbynens @ljharb
Editorial: Clarify RegExp grammar parameter N → NamedCaptureGroups (t…
1ac5e4a 
…c39#3120)

This makes the parameter more easily searchable while clarifying its meaning.

Issue: tc39#2411
@ljharb ljharb force-pushed the N-to-WithNamedCaptureGroups branch from 2390fb4 to 1ac5e4a Compare August 16, 2023 22:10
@ljharb ljharb merged commit 1ac5e4a into tc39:main Aug 16, 2023
@mathiasbynens mathiasbynens deleted the N-to-WithNamedCaptureGroups branch August 17, 2023 04:37
zhangenming pushed a commit to zhangenming/ecma262 that referenced this pull request Dec 22, 2023
@mathiasbynens
Editorial: Clarify RegExp grammar parameter N → NamedCaptureGroups (t…
e268684 
…c39#3120)

This makes the parameter more easily searchable while clarifying its meaning.

Issue: tc39#2411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

Assignees
No one assigned
Labels
ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mathiasbynens @michaelficarra @bakkot @ljharb